Fix cmake install targets #9822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`export(TARGETS ...)` is meant to allow for build trees to be found from other projects, however, writing the file to an installation directory causes buildtree paths to be hardcoded in the installed protobuf-targets.cmake
This allows for installation prefixes to match the intended installation directories, instead of being copied from the build tree.
|
I can't apply labels, but they should be just be |
13 tasks
acozzette
approved these changes
Apr 21, 2022
|
@jonringer Thanks! |
|
@acozzette of course :) Thanks for the speedy review |
acozzette
added a commit
to acozzette/protobuf
that referenced
this pull request
May 26, 2022
This reverts commit c80808c. Thix fixes protocolbuffers#10045. Somehow the change caused these four .cmake files to stop being installed: protobuf-config.cmake protobuf-config-version.cmake protobuf-module.cmake protobuf-options.cmake After reverting the change, I confirmed that the files are being installed again.
acozzette
added a commit
that referenced
this pull request
May 26, 2022
This reverts commit c80808c. Thix fixes #10045. Somehow the change caused these four .cmake files to stop being installed: protobuf-config.cmake protobuf-config-version.cmake protobuf-module.cmake protobuf-options.cmake After reverting the change, I confirmed that the files are being installed again.
srmainwaring
added a commit
to srmainwaring/protobuf
that referenced
this pull request
Apr 30, 2024
- Apply protocolbuffers#9822 Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to capture most of the context in the commit messages, so I'll just paste them here:
Fixes: #9809
TL;DR:
export(TARGETS ...)isn't meant to be used for installation, only local development. We should be usinginstall(EXPORT ...)for providing relocatable target locations.