Make StringPiece constructible from std::string_view #8707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves interop with certain string-like data structures, allowing to save extra allocation.
georgthegreat
commented
Jun 8, 2021
| @@ -214,6 +214,13 @@ class PROTOBUF_EXPORT StringPiece { | |||
| : ptr_(str.data()), length_(0) { | |||
There was a problem hiding this comment.
I tried to fix this one by replacing const string& with std::string_view, but certain cases were broken.
I. e. HasSuffixString(const string&, const string&) stops working as it requires 2 implicit ctors (and the standard only allows one).
This could be simplified with C++20 starts_with / ends_with, but this is a long story.
acozzette
reviewed
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves interop with certain string-like data structures, allowing to save extra allocation.