Make the dist_install test use Java 8 #8609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acozzette
force-pushed
the
fix-dist-install
branch
from
e712ac8
to
95ff3f8
Compare
dlj-NaN
reviewed
May 12, 2021
| @@ -29,3 +29,10 @@ RUN apt-get install -y \ | |||
| # -- For java_linkage_monitor \ | |||
| openjdk-8-jdk \ | |||
| && apt-get clean | |||
|
|
|||
| # Python dependencies | |||
| RUN apt-get install -y \ | |||
There was a problem hiding this comment.
You could merge the apt commands together, if you want. That would make the container slightly faster to build.
dlj-NaN
approved these changes
May 12, 2021
This is necessary because the Kotlin support requires Java 8 or higher. Making this test use Java 8 required switching it to the java_stretch Docker image and updating that image to include some Python dependencies.
acozzette
force-pushed
the
fix-dist-install
branch
from
95ff3f8
to
762e303
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary because the Kotlin support requires Java 8 or
higher.