Fix -Wunused-parameter in java_names.h #8601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgthegreat
commented
May 11, 2021
| @@ -154,7 +154,7 @@ std::string GetOneofStoredType(const FieldDescriptor* field); | |||
|
|
|||
| // Whether we should generate multiple java files for messages. | |||
| inline bool MultipleJavaFiles(const FileDescriptor* descriptor, | |||
| bool immutable) { | |||
There was a problem hiding this comment.
@acozzette, these methods are either planned to be rewritten in the future, or correspond to some deprecated approach.
They are just too simple, and can be entirely removed in most cases.
If you suggest a better way to fixing this (i. e. removing these methods entirely), I can take a look onto it.
There was a problem hiding this comment.
@georgthegreat Thanks for the cleanup! I think this should work except that our internal version of MultipleJavaFiles does use both parameters, so for this particular one I think it would be better to leave the parameter name but add something like (void) immutable;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.