Fix -Wunused-parameter in map<string, int> fields (fixes #8494) #8500
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a clumsy fix for #8494.
MWE is as follows:
During code generation, protoc will check for key / value types (corresponds to string_key / string_value variables all around).
If Utf8 validation will be disabled due to evaluation of
GetUtf8CheckMode()
tokNone
, theCheck()
method will be generated as follows:This will trigger
-Wunused-parameter
.