Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmake install on iOS #8301

Merged
merged 1 commit into from Mar 2, 2021

Conversation

anton-danielsson
Copy link
Contributor

Fixes:

INSTALL TARGETS given no BUNDLE DESTINATION for MACOSX_BUNDLE executable

The usefulness of these binaries on iOS can be discussed but it helps if the build "just works".
In my case this change will help to exclude special handling when using protobuf trough
the Conan package manager.

Fixes:
INSTALL TARGETS given no BUNDLE DESTINATION for MACOSX_BUNDLE executable
@google-cla google-cla bot added the cla: yes label Feb 16, 2021
@anton-danielsson
Copy link
Contributor Author

Ping?

I know the checks are failing but I assume I can't add labels myself? Or am I missing something?

@acozzette acozzette merged commit 630028a into protocolbuffers:master Mar 2, 2021
@anton-danielsson anton-danielsson deleted the fix/ios-protoc branch March 9, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants