Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more information to "file already loaded" warning. #8276

Merged
merged 1 commit into from Feb 11, 2021
Merged

Added more information to "file already loaded" warning. #8276

merged 1 commit into from Feb 11, 2021

Conversation

haberman
Copy link
Member

Also changed it to zend_error() so it is more easily suppressed.

Errors will now look like:

PHP Warning: proto descriptor was previously loaded (included in multiple metadata bundles?): google/ads/googleads/v6/errors/feed_item_validation_error.proto in /usr/local/google/home/haberman/code/google-ads-php/metadata/Google/Ads/GoogleAds/V6/Services/GoogleAdsService.php on line 29

Fixes #8124

@haberman
Added more information to "file already loaded" warning.
db66c95 
Also changed it to zend_error() so it is more easily suppressed.
@google-cla google-cla bot added the cla: yes label Feb 10, 2021
@haberman haberman mentioned this pull request Feb 10, 2021
Closed
@haberman haberman merged commit a97c4f4 into protocolbuffers:3.15.x Feb 11, 2021
@haberman haberman deleted the php-warning branch April 20, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acozzette acozzette acozzette approved these changes

Assignees
No one assigned
Labels
cla: yes php
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@haberman @acozzette @protobuf-kokoro