New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TextFormatMapTest.DynamicMessage issue#5136 #8159
Fix TextFormatMapTest.DynamicMessage issue#5136 #8159
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
This is the fix for this Issue# #5136 Issue: Google_protobuf failed to run the TextFormatMapTest.DynamicMessage with release configuration and debug configuration #5136 Issue observed in: Windows OS Reason for Issue: In windows OS, Each line ends with "CRLF" in a file. But in linux, Lines ends with "LF". In the TextFormatMapTest.DynamicMessage test case, Reading file in string contains "CRLF" at the end of each line which was the reason for string comparison failure. It was expecting "LF" instead of "CRLF". Solution: |
@googlebot I signed it! |
Please help to review, and merge. |
Clean up a multi-line string to conform to Unix line endings. Signed-off-by: Abhishek Jain <abhishek.jain3@huawei.com>
c766084
to
1fb6553
Compare
Thanks, @akjain2052. |
Clean up a multi-line string to conform to Unix line endings.