New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROTOBUF_MAYBE_CONSTEXPR should not be constexpr on MinGW #8049
Comments
@brechtsanders Thanks for reporting this, would you be interested in sending a pull request with that fix? |
Any chance this could be fixed in the near future? This blocks Bazel+Go users from using protos on Windows. Go is only compatible with gcc and clang (not MSVC), so users generally need to use mingw64, which means they also use it to build protoc. |
@acozzette as @brechtsanders does not seem to want to send a PR, is there anything blocking someone else to send this very small change? I think this is a copyright/legal issue, but can't quite imagine this would pose a legal problem due to its size. |
It's not that I dont want to make a pull request. Code changed substantially and I don't see where the fix for this issue should go in the changed code. |
Ok, I had a look at the latest code and created a pull request (#8286) |
Pull request is missing a label because it doesn't know the .inc file I changed is C source code. |
I tried to compile protobuf 3.14.0 for Windows with MinGW-w64 and got this compiler error:
It appears this is documented and fixed as an MSVC issue, but it seems to be a general Windows issue.
So after making the following change compilation was succesful:
The text was updated successfully, but these errors were encountered: