No need to generate addtional has method for proto2 #7802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haberman
requested changes
Aug 12, 2020
| @@ -119,11 +129,6 @@ public function setName($var) | |||
| return $this; | |||
| } | |||
|
|
|||
| public function hasName() | |||
There was a problem hiding this comment.
Removing this is technical a backward incompatible change. However since the method appears to be useless (has_name is never true AFAICS?) this will hopefully not be disruptive.
There was a problem hiding this comment.
The situation is that has method has already been generated generally.
Generating has methods for descriptors is a duplicate.
There was a problem hiding this comment.
I think has methods are not generated for repeated fields, and should not be.
So this is backward incompatible, but hopefully rarely used. Anyone who was using it should check the repeated field size instead.
haberman
approved these changes
Aug 12, 2020
vesavlad
pushed a commit
to vesavlad/protobuf
that referenced
this pull request
Sep 22, 2020
…7802) * No need to generate addtional has method for proto2 * Also remove has property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.