C#: MethodDescriptor.GetOption throws NullReferenceException

[JamesNK]

MethodDescriptor.GetOption<T>(Extension<MethodOptions, T> extension) throws NullReferenceException when the method descriptor does not have the option on it. I would expect it to return null.

My code:

private bool TryGetHttpRule(MethodDescriptor methodDescriptor, out HttpRule httpRule)
{
    var extension = AnnotationsExtensions.Http;
    httpRule = methodDescriptor.GetOption(extension);

    return httpRule != null;
}

Google.Protobuf 3.11.2
Google.Api.CommonProtos 2.0.0-beta01

[JamesNK]

Proto:

syntax = "proto3";

import "google/api/annotations.proto";
import "google/protobuf/wrappers.proto";
import "google/protobuf/empty.proto";

package http_api;

service HttpApiGreeter {
  rpc NoOption (HelloRequest) returns (HelloReply);
  rpc SayHello (HelloRequest) returns (HelloReply) {
    option (google.api.http) = {
      get: "/v1/greeter/{name}"
    };
  }
}

message HelloRequest {
  string name = 1;
}

message HelloReply {
  string message = 1;
}

MethodDescriptor that throws is NoOption

[jtattermusch]

This is fixed by introducing a new GetOptions() API and deprecating the "GetOption" API #7434.