Ruby lazy wrappers optimization #6797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few things that don't work or aren't tested yet: - wrappers at the top level - equality checking for not-yet-expanded wrappers.
… addressed. The only case that doesn't work is decoding a wrapper type from JSON at the top level. This doesn't make sense and probably no users do it I changed it to throw.
gerben-s
approved these changes
Oct 31, 2019
gerben-s
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimization avoids creating Ruby objects for wrapper types until they are accessed. Ruby has significant per-object overheads, both at allocation and GC time. In messages with lots of wrapper fields, this optimization speeds up parsing greatly.
At parse time, we store wrappers as primitive values in the message. If the field is never accessed, or is only accessed as
foo.bar_as_value, we never need to allocate a true Ruby object. Only if a user accessesfoo.bardirectly do we lazily create the Ruby object.