Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c# feature(RepeatedField): Capacity property to resize the internal array #6530

Merged
merged 1 commit into from Oct 18, 2019

Conversation

prat0088
Copy link
Contributor

@prat0088 prat0088 commented Aug 17, 2019

This property is useful for efficiently initializing long RepeatedFields.

I used System.Collections.Generic.List's design as a model. It should feel the most familiar to C# developers.

Fixes: #5501

…rray

This property is useful for efficiently initializing long RepeatedFields.

I used System.Collections.Generic.List's design as a model.  It should feel the most familiar to C# developers.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@prat0088
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@WilliamWhispell
Copy link
Contributor

I need this feature for my project. @anandolee - what is needed to get this merged?

Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the tests pass.

@jtattermusch jtattermusch self-assigned this Oct 18, 2019
@jtattermusch jtattermusch removed the request for review from anandolee October 18, 2019 13:13
@jtattermusch jtattermusch merged commit 2f7f670 into protocolbuffers:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make RepeatedField's EnsureSize() a public method in C#
5 participants