Backport GHA fixes and optimizations to 22.x #11944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiperOrigin-RevId: 508680514
PiperOrigin-RevId: 508701071
Changes to these files *can't* be tested in forked PRs, so we should explicitly block them with an error message to explain why. PiperOrigin-RevId: 508701535
PiperOrigin-RevId: 508720169
PiperOrigin-RevId: 508756680
Use the bash GHA to ensure WKTs are current, and then just directly invoke Xcode. This means the script full_mac_build.sh can go back to just being a simpler helper for folks doing local builds and we can remove all the extra support that was needed for CI. PiperOrigin-RevId: 508762464
These will still use MSVC as the compiler, but will no longer generate Visual Studio projects for the builds. Visual Studio is particularly bad at parallelizing builds, and is hostile to ccache. This change also tweaks the ccache setup to prevent unbounded the growth observed in our github caches. Windows builds have had debug symbols stripped to reduce ccache size by a factor of 2x, and ccache maximum have been tweaked so that we persist fewer older builds. Before this change, each CMake build took 12 minutes on every run (plus some constant overhead from staleness/gcloud), even with caching or on large multi-core runners. No amount of caching or parallelization made any noticeable difference above noise. With this change, we see the following improvements: - 12 minutes to build from scratch on normal runners (unchanged) - 4 minutes on 32-core runners from scratch - 1 minute with optimal caches available on normal runners. - 30 seconds on 32-core runners with optimal caches PiperOrigin-RevId: 508799909
PiperOrigin-RevId: 508944353
Placing it in the .github directory unexpectedly replaced our top-level documentation on the main page. PiperOrigin-RevId: 509104326
Both 'schedule' and 'workflow_dispatch' are valid alternatives today. What we really want here is anything *except* pull request events. PiperOrigin-RevId: 509123777
PiperOrigin-RevId: 509260795
PiperOrigin-RevId: 509409873
PiperOrigin-RevId: 509546035
mkruskal-google
added
release notes: no
back-port
zhangskz
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be merged not squashed