Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Abseil dependency from CMake build #10056

Merged
merged 2 commits into from
May 26, 2022

Conversation

acozzette
Copy link
Member

We will reintroduce this soon, but we do not want it to take effect yet in the current 3.21 release.

@acozzette acozzette merged commit f7e2e0b into protocolbuffers:21.x May 26, 2022
@acozzette acozzette deleted the absl branch May 26, 2022 19:13
@@ -30,7 +30,7 @@ git clone https://github.com/matthew-brett/multibuild.git
# silently creeping in (see https://github.com/protocolbuffers/protobuf/issues/9180).
# IMPORTANT: always pin multibuild at the same commit for:
# - linux/build_artifacts.sh
# - macos/build_artifacts.sh
# - linux/build_artifacts.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should NOT have been reverted same below

@yoavmil
Copy link
Contributor

yoavmil commented Sep 29, 2022

note that when I tried to install protobuf via vcpkg it gave an error message.
the install command:

PS ...\vcpkg> vcpkg upgrade protobuf:x64-windows --no-dry-run
The following packages will be rebuilt:
  * grpc[codegen,core]:x64-windows -> 1.49.0
  * protobuf[core]:x64-windows -> 3.21.6

the error message:

Error: Building package grpc:x64-windows failed with: BUILD_FAILED

and inside the log file:

CMake Error at CMakeLists.txt:2407 (target_link_libraries):
  Target "grpc" links to:

    absl::any_invocable
 vcpkg --version
Vcpkg package management program version 2022-03-09-1affd32f93b299d5a907816c328ca3ededb73a7e

@mkruskal-google
Copy link
Member

protobuf doesn't depend on grpc, so there should be no reason we're causing an upgrade of it. It sounds like you have a more recent version of gRPC installed that depends on Abseil, but don't have Abseil installed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants