From 0f25590028d90f5e525574b16a7b0f8a620cd63d Mon Sep 17 00:00:00 2001 From: Yuriy Chernyshov Date: Sat, 17 Apr 2021 01:52:10 +0300 Subject: [PATCH] Fix -Wunused-parameter in map fields (fixes #8494) (#8500) * Fix -Wunused-parameter in map fields * Fix tabs --- src/google/protobuf/compiler/cpp/cpp_map_field.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/google/protobuf/compiler/cpp/cpp_map_field.cc b/src/google/protobuf/compiler/cpp/cpp_map_field.cc index 44c913868a56..b1e3c1e50cbc 100644 --- a/src/google/protobuf/compiler/cpp/cpp_map_field.cc +++ b/src/google/protobuf/compiler/cpp/cpp_map_field.cc @@ -229,7 +229,10 @@ void MapFieldGenerator::GenerateSerializeWithCachedSizesToArray( if (utf8_check) { format( "struct Utf8Check {\n" - " static void Check(ConstPtr p) {\n"); + " static void Check(ConstPtr p) {\n" + // p may be unused when GetUtf8CheckMode evaluates to kNone, + // thus disabling the validation. + " (void)p;\n"); format.Indent(); format.Indent(); if (string_key) {