Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Huge bundle size! #124

Closed
sayjeyhi opened this issue Jul 28, 2022 · 4 comments · Fixed by #128
Closed

Huge bundle size! #124

sayjeyhi opened this issue Jul 28, 2022 · 4 comments · Fixed by #128
Labels
enhancement New feature or request good first issue Good for newcomers packaging & distribution triaged Issue has been triaged

Comments

@sayjeyhi
Copy link
Contributor

google-protobuf is adding about 50Kb gzipped to the bundle size! (230 minified)
Is there a way to improve this?
@egor-yolabs egor-yolabs mentioned this issue Aug 2, 2022
Open
@dibenede dibenede added enhancement New feature or request good first issue Good for newcomers packaging & distribution labels Aug 12, 2022
@dibenede
Copy link
Contributor

We are aware of the issue and agree we could do better. A good path forward would be to investigate tree shaking when building our runtime.

@dibenede dibenede added the triaged Issue has been triaged label Aug 12, 2022
@sayjeyhi
Copy link
Contributor Author

Can I work on this somehow?

@dibenede
Copy link
Contributor

You're welcome to take a look. Smaller, incremental, PRs might be the easiest way to tackle this. I see protocolbuffers/protobuf#5509 exists, which might be a good starting point.

@sayjeyhi sayjeyhi mentioned this issue Aug 24, 2022
Merged
@sayjeyhi
Copy link
Contributor Author

@dibenede I created this PR: #128

sayjeyhi added a commit to sayjeyhi/grpc-web that referenced this issue Oct 8, 2022
@sayjeyhi
upgrade google-protobuf version to fix bundle size issues
c092713 
Based on this issue: protocolbuffers/protobuf-javascript#124 on google-protobuf the new changes fixed and reduced the bundle size. So here we upgrade `google-protobuf` version to fix bundle size issues
@sayjeyhi sayjeyhi mentioned this issue Oct 8, 2022
Open
@X-oss-byte X-oss-byte mentioned this issue May 24, 2024
Open
@thiswayman thiswayman mentioned this issue May 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers packaging & distribution triaged Issue has been triaged
Projects
None yet
Milestone
No milestone
2 participants
@dibenede @sayjeyhi