feat: proto3 optional support #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For testing in Google Cloud client libraries, I published this from this branch as v6.11.0-pre (tagging it |
bcoe
approved these changes
Apr 14, 2021
murgatroid99
approved these changes
Apr 15, 2021
This was referenced Apr 28, 2021
Closed
dae
added a commit
to ankitects/protobuf.js
that referenced
this pull request
Feb 27, 2022
protobufjs#1584 made proto3 optional scalars default to null when using static/static-module, but the old behaviour remained when using reflection (eg json-module).
This was referenced Jul 8, 2022
Merged
|
Does the change for commets(cli/targets/static.js) be reset by other PR #1597 link |
renawolford6
added a commit
to renawolford6/protobuf-script-build-javascript
that referenced
this pull request
Nov 10, 2022
… (#1693) protobufjs/protobuf.js#1584 made proto3 optional scalars default to null when using static/static-module, but the old behaviour remained when using reflection (eg json-module).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for proto3
optionalfields as described in the design.Summary: if the proto has
syntax = "proto3";, then for everyoptionalfield the parser will create a synthetic single memberoneoffield. Also, in the static code (produced bypbjs), proto3optionalfields will be set tonullby default.