Ensure the URL part of links is not escaped #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As stated in the Commonmark specs backslash escapes do not work in Autolinks, so this prevents escaping Autolinks and should resolve ProseMirror#65.
8 tasks
|
Thanks! Merged as 48170d4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #65
When doing the markdown serialization ensure that the URL part of links is not escaped as backslash escapes are not allowed within autolinks and the URL part of "normal" links (as of common mark).
This prevents invalid URLs after serialization if Autolinks containing
_or~are used (every other special markdown symbol should be URL encoded anyways for URLs).Added also some tests to ensure this behavior.