Config : support disabling failure persistence via env var #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-russo
commented
Jan 6, 2023
| @@ -43,7 +43,10 @@ const FORK: &str = "PROPTEST_FORK"; | |||
| const TIMEOUT: &str = "PROPTEST_TIMEOUT"; | |||
| #[cfg(feature = "std")] | |||
| const VERBOSE: &str = "PROPTEST_VERBOSE"; | |||
| #[cfg(feature = "std")] | |||
There was a problem hiding this comment.
not strictly needed but noticed it was inconsistent
matthew-russo
force-pushed
the
276-env-var-disable-persistence
branch
from
079ad93
to
14396dc
Compare
cameron1024
approved these changes
Jan 6, 2023
proptest/src/test_runner/config.rs
Outdated
Comment on lines
226
to
228
| /// You can disable failure persistence with the `PROPTEST_DISABLE_FAILURE_PERSISTENCE` | ||
| /// environment variable but its not currently possible to set the persistence file | ||
| /// with an environment variable. |
There was a problem hiding this comment.
There was recently a PR adding a comment to these saying "the env var only has an effect when the std feature is enabled". I'm assuming that applies here? If so, should we add that warning?
matthew-russo
force-pushed
the
276-env-var-disable-persistence
branch
from
14396dc
to
cd121d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #276