Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consul should use prometheus/common HTTPClient #8924

Closed
roidelapluie opened this issue Jun 11, 2021 · 2 comments · Fixed by #8926
Closed

Consul should use prometheus/common HTTPClient #8924

roidelapluie opened this issue Jun 11, 2021 · 2 comments · Fixed by #8926

Comments

@roidelapluie
Copy link
Member

roidelapluie commented Jun 11, 2021

With prometheus/common#308, consul should be able to use the full common's http client.

It means that it can get the ability to read its token and basic auth password from a file.

Currently we only use the TLS part.

Notes:

  • We must stay compatible with the current config (when unmarshalling, turn provided username and password into http client basicauth).
  • We should check that authorization is not set at the same time as consul token. If it is the case, error.
  • if a consul token is passed, it should still be passed to the consul client, because I think it uses X-Consul-Token, which is needed to connect to old consul, that does not support Authorization header. So consul_token should still be documented.
  • if username and basic_auth.username are set, we should error. Same for password.
@roidelapluie
Copy link
Member Author

cc @LeviHarrison

@roidelapluie roidelapluie changed the title Consul should use the HTTPClient Consul should use prometheus/common HTTPClient Jun 11, 2021
@roidelapluie
Copy link
Member Author

For the record, Levi is working on this.

@prometheus prometheus locked as resolved and limited conversation to collaborators Dec 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant