Add --lint-fatal option #10815
Merged
Add --lint-fatal option #10815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps the previous behaviour of printing details about duplicate rules but doesn't exit with a fatal exit code unless turned on. Signed-off-by: David Leadbeater <dgl@dgl.cx>
roidelapluie
approved these changes
Jun 3, 2022
This was referenced Jun 3, 2022
roidelapluie
pushed a commit
to roidelapluie/prometheus
that referenced
this pull request
Jun 9, 2022
This keeps the previous behaviour of printing details about duplicate rules but doesn't exit with a fatal exit code unless turned on. Signed-off-by: David Leadbeater <dgl@dgl.cx>
roidelapluie
pushed a commit
to roidelapluie/prometheus
that referenced
this pull request
Jun 9, 2022
This keeps the previous behaviour of printing details about duplicate rules but doesn't exit with a fatal exit code unless turned on. Signed-off-by: David Leadbeater <dgl@dgl.cx>
roidelapluie
added a commit
that referenced
this pull request
Jun 9, 2022
roidelapluie
added a commit
that referenced
this pull request
Jun 9, 2022
* Fix UI build (#10842) Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu> * Add --lint-fatal option (#10815) (#10840) This keeps the previous behaviour of printing details about duplicate rules but doesn't exit with a fatal exit code unless turned on. Signed-off-by: David Leadbeater <dgl@dgl.cx> Co-authored-by: David Leadbeater <dgl@dgl.cx> * Add v2.36.1 CHANGELOG and VERSION update Signed-off-by: Matthias Loibl <mail@matthiasloibl.com> Co-authored-by: Julien Pivotto <roidelapluie@inuits.eu> Co-authored-by: David Leadbeater <dgl@dgl.cx>
roidelapluie
pushed a commit
to roidelapluie/prometheus
that referenced
this pull request
Jun 22, 2022
This keeps the previous behaviour of printing details about duplicate rules but doesn't exit with a fatal exit code unless turned on. Signed-off-by: David Leadbeater <dgl@dgl.cx>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This keeps the previous behaviour of printing details about duplicate
rules but doesn't exit with a fatal exit code unless turned on.
Signed-off-by: David Leadbeater dgl@dgl.cx