Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strings.TrimRight is used instead of TrimSuffix #507

Closed
GrosQuildu opened this issue Apr 18, 2023 · 1 comment · Fixed by #618
Closed

strings.TrimRight is used instead of TrimSuffix #507

GrosQuildu opened this issue Apr 18, 2023 · 1 comment · Fixed by #618

Comments

@GrosQuildu
Copy link

GrosQuildu commented Apr 18, 2023 •
edited

This line aims to remove " kB" suffix, but instead removes all characters from " kB" cutset.

procfs/proc_smaps.go

Line 130 in cdc4512

v = strings.TrimRight(v, " kB")

Similar fix as was done in this commit is required - b3d77ec .
@discordianfish
Copy link
Member

Oops, thanks! Wanna submit a quick PR to fix this?

rexagod added a commit to rexagod/procfs that referenced this issue Mar 21, 2024
@rexagod
bugfix: s/TrimRight/TrimSuffix for certain cases
680ecde 
Use `TrimSuffix` instead of `TrimRight` in cases where an exact suffix
string needs to be removed, not all occurrences of all characters in a
specified cutset.

Fixes: prometheus#507

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
@rexagod rexagod mentioned this issue Mar 21, 2024
Merged
SuperQ pushed a commit that referenced this issue May 12, 2024
@rexagod
bugfix: s/TrimRight/TrimSuffix for certain cases (#618)
1adce6b 
Use `TrimSuffix` instead of `TrimRight` in cases where an exact suffix
string needs to be removed, not all occurrences of all characters in a
specified cutset.

Fixes: #507

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugfix: s/TrimRight/TrimSuffix for certain cases rexagod/procfs
2 participants
@discordianfish @GrosQuildu