Move fixtures to testdata folder #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dprotaso
force-pushed
the
fixture-to-testdata
branch
8 times, most recently
from
b63c923
to
07c6318
Compare
This prevents the test fixtures from being shipped around in the module cache. ie. Prior if project A has a dependency on this project then running `go mod vendor` will pull the fixtures.ttar into the vendor folder Signed-off-by: dprotaso <dprotaso@gmail.com>
dprotaso
force-pushed
the
fixture-to-testdata
branch
from
07c6318
to
43dc666
Compare
|
@SuperQ this is ready |
|
Oh I did not know that testdata/ is treated differently. Interesting. But LGTM in general. |
remijouannet
pushed a commit
to remijouannet/procfs
that referenced
this pull request
Oct 20, 2022
This prevents the test fixtures from being shipped around in the module cache. ie. Prior if project A has a dependency on this project then running `go mod vendor` will pull the fixtures.ttar into the vendor folder Signed-off-by: dprotaso <dprotaso@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the test fixtures from being shipped around in the module
cache. ie. Prior if project A has a dependency on this project then running
go mod vendorwill pull the fixtures.ttar into the vendor folder