New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent panic if status line is empty in mdstat #441
Conversation
Thanks, looks reasonable! You still need to sign-off your commit though. Ignore the circleci issues, we'll fix them. And curious, where did you see mdstat having an empty line? |
Looks like my public email setting was incorrect - can we somehow rerun the tests here? It should pass now. I can't really say what exactly happened (I didn't log the mdstat contents), but sporadically I was able to see panics caused by that particular line. |
DCO complains with this:
|
You might need to edit the email in your git commit and force push. |
ed8f4a3
to
3f75f0d
Compare
You might need to rebase to pick up the lint fixes |
Hello, is there anything else I can do to make this change merged and release a new version, so it can be picked up by Go modules? |
If you could rebase your fork and branch, that should fix up the tests.
|
This change fixes a potential source of panic when the status line in mdstat is empty and the code is trying to reference first item in a zero-sized slice. Signed-off-by: Artur Makutunowicz <arma@linkedin.com>
3f75f0d
to
02e9fa9
Compare
@SuperQ Thanks, that seemed to work! |
This change fixes a potential source of panic when the status line in mdstat is empty and the code is trying to reference first item in a zero-sized slice. Signed-off-by: Artur Makutunowicz <arma@linkedin.com>
This change fixes a potential source of panic when the status line in
mdstat is empty and the code is trying to reference the first item in a
zero-sized slice.
@discordianfish @pgier
Signed-off-by: Artur Makutunowicz artur@makutunowicz.net