Fixed ARP table MAC address parsing, added Flags field #414
+64
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
und3f
force-pushed
the
master
branch
2 times, most recently
from
a54dd01
to
b33f9f4
Compare
- Added ARPEntry.Flags field related to entry flags - Added ARPEntry.IsComplete() to check if entry is complete - Fixed mac address parsing and error handling - Test improved with incomplete entry information Closes prometheus#413. Signed-off-by: Serhii Zasenko <sergii@zasenko.name>
und3f
changed the title
|
Minor cleanup of the const names, but otherwise this is great. |
Signed-off-by: Serhii Zasenko <sergii@zasenko.name>
|
Glad it suits!) |
remijouannet
pushed a commit
to remijouannet/procfs
that referenced
this pull request
Oct 20, 2022
* fixed arp table mac address parsing - Added ARPEntry.Flags field related to entry flags - Added ARPEntry.IsComplete() to check if entry is complete - Fixed mac address parsing and error handling - Test improved with incomplete entry information Closes prometheus#413. Signed-off-by: Serhii Zasenko <sergii@zasenko.name> * Arp flag const names cleanup Signed-off-by: Serhii Zasenko <sergii@zasenko.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Incomple arp entries are returned with MAC address 30:30:3a:... #413.
Signed-off-by: Serhii Zasenko sergii@zasenko.name