New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add device-mapper-specific block device properties #412
Add device-mapper-specific block device properties #412
Conversation
This needs a rebase to update the fixtures file. |
Signed-off-by: W. Andrew Denton <git@flying-snail.net>
Signed-off-by: W. Andrew Denton <git@flying-snail.net>
Signed-off-by: W. Andrew Denton <git@flying-snail.net>
Signed-off-by: W. Andrew Denton <git@flying-snail.net>
ac393dc
to
2129811
Compare
Signed-off-by: W. Andrew Denton <git@flying-snail.net>
Signed-off-by: W. Andrew Denton <git@flying-snail.net>
Signed-off-by: W. Andrew Denton <git@flying-snail.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits, otherwise LGTM.
Signed-off-by: W. Andrew Denton <git@flying-snail.net>
Alright, I've capitalized all of the "Files with" comments (there were a few existing ones too). |
@SuperQ PTAL |
Hi there. Waiting for this feature a lot in a new build. @SuperQ could you please take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks!
* Expose device-mapper information as DeviceMapperInfo Signed-off-by: W. Andrew Denton <git@flying-snail.net> * Enumerate block device slaves as UnderlyingDeviceInfo Signed-off-by: W. Andrew Denton <git@flying-snail.net> * Add missing fixtures. Signed-off-by: W. Andrew Denton <git@flying-snail.net> * blockdevice/stats: uppercase initialisms. Signed-off-by: W. Andrew Denton <git@flying-snail.net> * Expose device-mapper information as DeviceMapperInfo Signed-off-by: W. Andrew Denton <git@flying-snail.net> * Expose device-mapper information as DeviceMapperInfo Signed-off-by: W. Andrew Denton <git@flying-snail.net> * Update fixtures. Signed-off-by: W. Andrew Denton <git@flying-snail.net> * Capitalize comments. Signed-off-by: W. Andrew Denton <git@flying-snail.net> Co-authored-by: W. Andrew Denton <git@flying-snail.net>
Expose block device-mapper properties. This will enable node_exporter to expose the device-mapper information in a node_disk_info metric. (PR on that to follow.)
Closes #211.
Signed-off-by: W. Andrew Denton git@flying-snail.net