Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device-mapper-specific block device properties #412

Merged
merged 8 commits into from Jan 10, 2022

Conversation

ventifus
Copy link
Contributor

Expose block device-mapper properties. This will enable node_exporter to expose the device-mapper information in a node_disk_info metric. (PR on that to follow.)
Closes #211.

Signed-off-by: W. Andrew Denton git@flying-snail.net

@ventifus ventifus changed the title Blockdevice stats devicemapper Add device-mapper stats Sep 14, 2021
@ventifus ventifus changed the title Add device-mapper stats Add device-mapper-specific block device properties Sep 14, 2021
@SuperQ
Copy link
Member

SuperQ commented Oct 31, 2021

This needs a rebase to update the fixtures file.

W. Andrew Denton added 4 commits November 19, 2021 11:18
Signed-off-by: W. Andrew Denton <git@flying-snail.net>
Signed-off-by: W. Andrew Denton <git@flying-snail.net>
Signed-off-by: W. Andrew Denton <git@flying-snail.net>
Signed-off-by: W. Andrew Denton <git@flying-snail.net>
@ventifus ventifus force-pushed the blockdevice-stats-devicemapper branch from ac393dc to 2129811 Compare November 19, 2021 19:19
W. Andrew Denton added 3 commits November 19, 2021 11:21
Signed-off-by: W. Andrew Denton <git@flying-snail.net>
Signed-off-by: W. Andrew Denton <git@flying-snail.net>
Signed-off-by: W. Andrew Denton <git@flying-snail.net>
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, otherwise LGTM.

blockdevice/stats.go Outdated Show resolved Hide resolved
blockdevice/stats.go Outdated Show resolved Hide resolved
Signed-off-by: W. Andrew Denton <git@flying-snail.net>
@ventifus
Copy link
Contributor Author

ventifus commented Dec 4, 2021

Alright, I've capitalized all of the "Files with" comments (there were a few existing ones too).

@discordianfish
Copy link
Member

@SuperQ PTAL

@ddpolyakov
Copy link

Hi there. Waiting for this feature a lot in a new build. @SuperQ could you please take a look?

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@SuperQ SuperQ merged commit fbe360a into prometheus:master Jan 10, 2022
remijouannet pushed a commit to remijouannet/procfs that referenced this pull request Oct 20, 2022
* Expose device-mapper information as DeviceMapperInfo

Signed-off-by: W. Andrew Denton <git@flying-snail.net>

* Enumerate block device slaves as UnderlyingDeviceInfo

Signed-off-by: W. Andrew Denton <git@flying-snail.net>

* Add missing fixtures.

Signed-off-by: W. Andrew Denton <git@flying-snail.net>

* blockdevice/stats: uppercase initialisms.

Signed-off-by: W. Andrew Denton <git@flying-snail.net>

* Expose device-mapper information as DeviceMapperInfo

Signed-off-by: W. Andrew Denton <git@flying-snail.net>

* Expose device-mapper information as DeviceMapperInfo

Signed-off-by: W. Andrew Denton <git@flying-snail.net>

* Update fixtures.

Signed-off-by: W. Andrew Denton <git@flying-snail.net>

* Capitalize comments.

Signed-off-by: W. Andrew Denton <git@flying-snail.net>

Co-authored-by: W. Andrew Denton <git@flying-snail.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add parsing of Device Mapper Slave Devices
4 participants