Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for DMI information #409

Merged
merged 1 commit into from Oct 11, 2021
Merged

Add support for DMI information #409

merged 1 commit into from Oct 11, 2021

Conversation

bdrung
Copy link
Contributor

@bdrung bdrung commented Aug 26, 2021

The sysfs contains some useful information about the BIOS, board, chassis, product, and system from the Desktop Management Interface (DMI). The BIOS version should be exported by the Prometheus node exporter to support alerting about outdated BIOS versions. Add a DMIClass function to collect the information for the node exporter.

@bdrung bdrung mentioned this pull request Aug 26, 2021
Closed
SuperQ
SuperQ reviewed Aug 26, 2021
View reviewed changes
sysfs/class_dmi.go Outdated Show resolved Hide resolved
SuperQ
SuperQ approved these changes Aug 27, 2021
View reviewed changes
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdrung
Add support for DMI information
fccb157 
The sysfs contains some useful information about the BIOS, board,
chassis, product, and system from the Desktop Management Interface
(DMI). The BIOS version should be exported by the Prometheus node
exporter to support alerting about outdated BIOS versions. Add a
`DMIClass` function to collect the information for the node exporter.

Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
@bdrung
Copy link
Contributor Author

bdrung commented Aug 27, 2021

I needed to change the f.IsDir() to !f.Mode().IsRegular() since this directory can also contain symlinks to directories.

@bdrung bdrung mentioned this pull request Aug 27, 2021
Merged
discordianfish
discordianfish approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@discordianfish discordianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@bdrung
Copy link
Contributor Author

bdrung commented Oct 11, 2021

Any updates on this merge request?

@discordianfish
Copy link
Member

Oh sorry, I didn't realize SuperQ already approved.

@discordianfish discordianfish merged commit 1a7a2bd into prometheus:master Oct 11, 2021
@bdrung bdrung deleted the dmi branch October 12, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@discordianfish discordianfish discordianfish approved these changes

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bdrung @discordianfish @SuperQ