Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with GopherJS #406

Merged
merged 1 commit into from Aug 27, 2021
Merged

Conversation

paralin
Copy link
Contributor

@paralin paralin commented Aug 4, 2021

Fixes build with "gopherjs build ." by excluding proc_maps.go from the build.

@discordianfish
Copy link
Member

Curious, why doesn't it build? And what are you using this for in gopherjs context?

Signed-off-by: Christian Stewart <christian@paral.in>
@paralin
Copy link
Contributor Author

paralin commented Aug 22, 2021

GopherJS sets both "js" and "linux" - that file references "golang.org/x/sys/unix" which can't be referenced from GopherJS.

As for why, I'm running the Prometheus client and metrics generator in the browser. :)

Copy link
Member

@discordianfish discordianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah makes sense. Thanks!

@paralin
Copy link
Contributor Author

paralin commented Aug 26, 2021

Merge? :D

@SuperQ SuperQ merged commit 4d08435 into prometheus:master Aug 27, 2021
remijouannet pushed a commit to remijouannet/procfs that referenced this pull request Oct 20, 2022
Signed-off-by: Christian Stewart <christian@paral.in>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants