Endpoint authentication via web.config not available anymore in 1.5.0

[justusbunsi]

Host operating system: output of uname -a

Linux <server-name-redacted> 5.10.0-21-amd64 #1 SMP Debian 5.10.162-1 (2023-01-21) x86_64 GNU/Linux

node_exporter version: output of node_exporter --version

node_exporter, version 1.5.0 (branch: HEAD, revision: 1b48970ffcf5630534fb00bb0687d73c66d1c959)
  build user:       root@6e7732a7b81b
  build date:       20221129-18:59:09
  go version:       go1.19.3
  platform:         linux/amd64

node_exporter command line flags

/usr/local/bin/node_exporter --web.config=/etc/node-exporter-web-config.yaml

node_exporter log output

node_exporter: error: unknown long flag '--web.config', try --help

Are you running node_exporter in Docker?

No.

What did you do that produced an error?

Update from 1.4.0 to 1.5.0.

What did you expect to see?

Service node_exporter running successfully with experimental endpoint authentication enabled.

What did you see instead?

Service node_exporter failed to start because of log output above (missing --web.config flag).

Additional notes

Although the README still refers to that experimental feature, Pull Request #2393 removed it from the code base¹. There was no conversation about that removal in the Pull Request. The exporter-toolkit was updated, but it seems that the new version still supports that feature. Was there a discussion to remove that experimental feature which I am missing?

Footnotes

1. https://github.com/prometheus/node_exporter/pull/2393/files#diff-7907251477470326df65250bf7fa699e0756ce5d6282e27b34c112132a7ef6b5L165-L168 ↩

[justusbunsi]

😅 Just saw https://github.com/prometheus/node_exporter/blob/master/CHANGELOG.md#150--2022-11-29. It might be worth mentioning it in the official release page of 1.5.0 as well.

NOTE: A command line arg has been changed from --web.config to --web.config.file.

[mmospanenko]

Breaking changes in minor version? Without any 'deprecated' warnings?

[SuperQ]

This feature is still considered experimental.