Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NULL character on k8s zone labels #521

Open
luisdavim opened this issue Oct 5, 2023 · 0 comments
Open

NULL character on k8s zone labels #521

luisdavim opened this issue Oct 5, 2023 · 0 comments

Comments

@luisdavim
Copy link

A related issue was opened some time ago kubernetes/kubernetes#73867

This https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/component-helpers/node/topology/helpers.go#L57 adds the NULL character and then because in prometheus %q is used to print the value https://github.com/prometheus/common/blob/main/model/metric.go#L62 the character is printed.

If it makes sense to you I can open a PR to strip these characters from the label values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant