Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong json umarshal bug for model value #398

Open
kitianFresh opened this issue Aug 3, 2022 · 1 comment
Open

Wrong json umarshal bug for model value #398

kitianFresh opened this issue Aug 3, 2022 · 1 comment

Comments

@kitianFresh
Copy link

func (v *SampleValue) UnmarshalJSON(b []byte) error {

I found a strange bug, the response data unmarshalled by prom client-go is wrong by chance.

I use the queryRange API provided by prometheus client go as followings

image

and i print the time series data returned by the queryRange api, it has unexpected data value. it is very large and unexpected.

image

the value logged function is below, i use json marshal directly to marshal the returned data by api, i am sure that this is the data returned by prometheus client-go api queryRange function:

image

and then i use curl curl -G --data-urlencode 'query=irate(container_cpu_usage_seconds_total{container!="POD",namespace="ns-prjchlvc-1544041-production",pod=~"^monitor-server-siliconvalley-150001.*$",container="second-monitor-server"}[3m])' --data-urlencode 'start=1658205420.000' --data-urlencode 'end=1658865360.000' --data-urlencode 'step=60' http://127.0.0.1:9090/api/v1/query_range to query the prometheus directly, it returned normal data as expected. you can see the following data timestamp and value, it is what we want. but the above image is use the client-go api, with the same param, it has unexpected value at the same timestamp.

image

So i think the json unmarshal has some bug the prometheus client go impelmented

@kitianFresh
Copy link
Author

@roidelapluie Anyone can help? thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant