config: ignore deprecated warning in tests #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(*CertPool).Subjects is deprecated in Go 1.18 because it may not include the system certs but it isn't a problem for the tests because we're not loading the system certs. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
|
Thanks! |
radek-ryckowski
pushed a commit
to goldmansachs/common
that referenced
this pull request
May 18, 2023
(*CertPool).Subjects is deprecated in Go 1.18 because it may not include the system certs but it isn't a problem for the tests because we're not loading the system certs. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
radek-ryckowski
pushed a commit
to goldmansachs/common
that referenced
this pull request
May 22, 2023
(*CertPool).Subjects is deprecated in Go 1.18 because it may not include the system certs but it isn't a problem for the tests because we're not loading the system certs. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(*CertPool).Subjects is deprecated in Go 1.18 because it may not include
the system certs but it isn't a problem for the tests because we're not
loading the system certs.
Follow-up to #388 which we would need to upgrade to the latest golangci-lint version.