Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more mimetypes #385

Merged
merged 2 commits into from Jun 17, 2022
Merged

Add more mimetypes #385

merged 2 commits into from Jun 17, 2022

Conversation

roidelapluie
Copy link
Member

Signed-off-by: Julien Pivotto roidelapluie@o11y.eu

Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
@Nexucis
Copy link
Member

Nexucis commented Jun 17, 2022

to avoid the same situation, can you add more mimes. For example this list should cover all cases we have in React:

https://github.com/perses/perses/blob/main/internal/api/front/generate.go#L31-L43

@Nexucis
Copy link
Member

Nexucis commented Jun 17, 2022

by checking on https://developer.mozilla.org/fr/docs/Web/HTTP/Basics_of_HTTP/MIME_types/Common_types, it looks like my MimeTypes are not accurate for JS and ICO but for the rest they are correct.

If you can update the list, we should be good for a while

Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
@roidelapluie
Copy link
Member Author

cjs
css
eot

ico
js
json
less
map
svg
ttf
txt
woff
woff2

is what we have. I have removed html from the list for now.

Copy link
Member

@Nexucis Nexucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Just in case, the react-app has an index.html. SO HTML file exist. But I think anyway we are good like that. HTML files seems to be naturally supported somehow lol.

@roidelapluie roidelapluie changed the title Add mome mimetypes Add more mimetypes Jun 17, 2022
@roidelapluie roidelapluie merged commit 26d4974 into prometheus:main Jun 17, 2022
radek-ryckowski pushed a commit to goldmansachs/common that referenced this pull request May 18, 2023

Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
radek-ryckowski pushed a commit to goldmansachs/common that referenced this pull request May 22, 2023

Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants