Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove go 1.15 #372

Merged
merged 1 commit into from Apr 21, 2022
Merged

Remove go 1.15 #372

merged 1 commit into from Apr 21, 2022

Conversation

mrueg
Copy link
Contributor

@mrueg mrueg commented Apr 13, 2022 •
edited

Removes go 1.15 / sets minimum go version to 1.16.
See also: #371

@mrueg mrueg force-pushed the remove-go-1.15 branch 3 times, most recently from 2738c4f to fef8a81 Compare April 13, 2022 17:58
@mrueg
Copy link
Contributor Author

mrueg commented Apr 13, 2022 •
edited

Looks like test-certificates are not working anymore due to deprecation/removal for rsa-sha1 certs in go 1.18. See golang/go#41682

@roidelapluie
Copy link
Member

yes, you'll need to generate new ones

@mrueg
Copy link
Contributor Author

mrueg commented Apr 21, 2022

Just saw that @kakkoyun had already started working on this: #363 I'll likely remove the go 1.18 piece from this PR and just remove 1.15

For the broken certs, I guess the ideal solution would be a script that generates them so people don't have to remember how to recreate them 😅

@mrueg
Set minimum version for go to 1.16
34514ef 
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
@mrueg mrueg changed the title Add support for go 1.18 / Remove go 1.15 Remove go 1.15 Apr 21, 2022
@roidelapluie roidelapluie merged commit 627089d into prometheus:main Apr 21, 2022
@roidelapluie
Copy link
Member

Thanks

radek-ryckowski pushed a commit to goldmansachs/common that referenced this pull request May 18, 2023
@mrueg @radek-ryckowski
Set minimum version for go to 1.16 (prometheus#372)
b60c01a 
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
radek-ryckowski pushed a commit to goldmansachs/common that referenced this pull request May 22, 2023
@mrueg @radek-ryckowski
Set minimum version for go to 1.16 (prometheus#372)
352c05b 
Signed-off-by: Manuel Rüger <manuel@rueg.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrueg @roidelapluie @kakkoyun