Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: add support for Digest authentication for scrape targets #352

Open
Tailzip opened this issue Dec 25, 2021 · 4 comments
Open

Feature request: add support for Digest authentication for scrape targets #352

Tailzip opened this issue Dec 25, 2021 · 4 comments

Comments

@Tailzip
Copy link

Tailzip commented Dec 25, 2021

Proposal

Add support for Digest authentification (in addition to already existing Basic authentication) for scrape targets.
@Tailzip Tailzip changed the title Dec 25, 2021
@LeviHarrison LeviHarrison transferred this issue from prometheus/prometheus Dec 25, 2021
@LeviHarrison
Copy link
Member

Transferring to the appropriate repo.

@LeviHarrison
Copy link
Member

I'm not familiar with Digest authentication, but given that it's not included in the Go standard http library, I think it might be too niche to support.

cc @roidelapluie

@roidelapluie
Copy link
Member

Indeed. Digest requires an extra roundtrip and does not bring added value. If you want to secure the authorization please use basic auth with tls.

@muety
Copy link

muety commented Dec 14, 2023

Would love to have digest auth support, because wanting to scrape targets that only support such.

muety added a commit to muety/common that referenced this issue Dec 14, 2023
@muety
feat: implement support for http digest auth (resolve prometheus#352)
693e51d
@muety muety mentioned this issue Dec 14, 2023
Open
muety added a commit to muety/common that referenced this issue Dec 14, 2023
@muety
feat: implement support for http digest auth (resolve prometheus#352)
25b2e9f 
Signed-off-by: Ferdinand Mütsch <ferdinand@muetsch.io>
muety added a commit to muety/common that referenced this issue Dec 14, 2023
@muety
feat: implement support for http digest auth (resolve prometheus#352)
1816b4b 
Signed-off-by: Ferdinand Mütsch <ferdinand@muetsch.io>
muety added a commit to muety/common that referenced this issue Jan 1, 2024
@muety
feat: implement support for http digest auth (resolve prometheus#352)
667bba1 
Signed-off-by: Ferdinand Mütsch <ferdinand@muetsch.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@roidelapluie @Tailzip @muety @LeviHarrison