Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sigv4 module #310

Merged
merged 7 commits into from Jun 23, 2021
Merged

Add sigv4 module #310

merged 7 commits into from Jun 23, 2021

Conversation

treid314
Copy link
Contributor

This contains the sigv4 config and sig v4 roundtripper. Do I need to add a new makefile for this module as well?

Tyler Reid added 2 commits June 16, 2021 16:40
…d secret key

Signed-off-by: Tyler Reid <tyler.reid@grafana.com>

Signed-off-by: Tyler Reid <tyler.reid@grafana.com>
…roundtripper

Signed-off-by: Tyler Reid <tyler.reid@grafana.com>
sigv4/sigv4.go Outdated Show resolved Hide resolved
Signed-off-by: Tyler Reid <tyler.reid@grafana.com>
@roidelapluie
Copy link
Member

roidelapluie commented Jun 21, 2021

yes, it would be nice to add a Makefile and call it from the main makefile or from ci

return fmt.Errorf("must provide a AWS SigV4 Access key and Secret Key if credentials are specified in the SigV4 config")
}
return nil
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing empty line.

@roidelapluie
Copy link
Member

Thanks, I have added 2 small comments.

Tyler Reid added 3 commits June 22, 2021 10:48
Signed-off-by: Tyler Reid <tyler.reid@grafana.com>
Signed-off-by: Tyler Reid <tyler.reid@grafana.com>
Signed-off-by: Tyler Reid <tyler.reid@grafana.com>
.circleci/config.yml Show resolved Hide resolved
sigv4/Makefile Outdated Show resolved Hide resolved
@roidelapluie
Copy link
Member

Thanks, we are getting close :)

Signed-off-by: Tyler Reid <tyler.reid@grafana.com>
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@roidelapluie roidelapluie merged commit 448ba39 into prometheus:main Jun 23, 2021
@roidelapluie
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants