Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace go-kit/kit with go-kit/log #304

Merged
merged 1 commit into from Jun 3, 2021

Conversation

dims
Copy link

@dims dims commented Jun 3, 2021

github.com/go-kit/kit is only being used for the log packages and brings in a lot of dependencies as compared to github.com/go-kit/log. This would help determine how useful switching would be.

For reference see kubernetes/kubernetes#102144 and this discussion.

Fix for #255

Signed-off-by: RinkiyaKeDad <arshsharma461@gmail.com>
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims changed the title replaced go-kit/kit with go-kit/log Replace go-kit/kit with go-kit/log Jun 3, 2021
@lilic
Copy link

lilic commented Jun 3, 2021

Thank you!! 💯 I wanted to bump client_golang and common in etcd, but couldn't due to the go-kit needing etcd :D

cc @roidelapluie

@roidelapluie roidelapluie merged commit 0ec6a33 into prometheus:main Jun 3, 2021
@roidelapluie
Copy link
Member

Thanks!

mrueg added a commit to mrueg/pushgateway that referenced this pull request Aug 4, 2021
See also: prometheus/common#304

Signed-off-by: Manuel Rüger <manuel@rueg.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants