Extend version.Print with platform info #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
|
From context, I think @roidelapluie wants this in the logs so we can easily see it when users post issues. Having it only show on an extra command run doesn't really help. |
In the referenced issue the output looks exactly like from |
|
Yes it is in prometheus --version as that is what we ask users to provide |
roidelapluie
approved these changes
Sep 23, 2020
|
We often only get the tail of the logs for users. |
|
Thanks! |
alanprot
pushed a commit
to alanprot/common
that referenced
this pull request
Mar 15, 2023
Update CI build to Go 1.17; drop BUILD_IN_CONTAINER
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For prometheus/prometheus#7962