We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Help strings should end with a period, per Prometheus guidance. But if a user does that themselves, the help string will be incorrect, as "a full stop punctuation mark (.) is automatically added to the passed help text" given to Registry::register.
Probably the best solution here is to append the period only if it doesn't already exist.
The text was updated successfully, but these errors were encountered:
Added to #52. Thanks @08d2. Let me know in case you want to tackle any of these.
Sorry, something went wrong.
I'm suggesting that help strings should be allowed to end in periods without that resulting in .. on scrape. Happy to PR if that's what it takes 👍
..
No branches or pull requests
Help strings should end with a period, per Prometheus guidance. But if a user does that themselves, the help string will be incorrect, as "a full stop punctuation mark (.) is automatically added to the passed help text" given to Registry::register.
Probably the best solution here is to append the period only if it doesn't already exist.
The text was updated successfully, but these errors were encountered: