diff --git a/src/encoding.rs b/src/encoding.rs index 52fa668..d3a725f 100644 --- a/src/encoding.rs +++ b/src/encoding.rs @@ -299,7 +299,6 @@ enum LabelValueEncoderInner<'a> { impl<'a> LabelValueEncoder<'a> { /// Finish encoding the label value. - #[must_use] pub fn finish(self) -> Result<(), std::fmt::Error> { for_both!(self, LabelValueEncoderInner, e, e.finish()) } @@ -394,13 +393,13 @@ impl<'a> EncodeLabelValue for Cow<'a, str> { } } -impl<'a> EncodeLabelValue for f64 { +impl EncodeLabelValue for f64 { fn encode(&self, encoder: &mut LabelValueEncoder) -> Result<(), std::fmt::Error> { encoder.write_str(dtoa::Buffer::new().format(*self)) } } -impl<'a> EncodeLabelValue for u64 { +impl EncodeLabelValue for u64 { fn encode(&self, encoder: &mut LabelValueEncoder) -> Result<(), std::fmt::Error> { encoder.write_str(itoa::Buffer::new().format(*self)) } diff --git a/src/encoding/text.rs b/src/encoding/text.rs index e8bb98c..4b9b7d7 100644 --- a/src/encoding/text.rs +++ b/src/encoding/text.rs @@ -209,7 +209,7 @@ impl<'a, 'b> MetricEncoder<'a, 'b> { self.newline()?; let mut cummulative = 0; - for (i, (upper_bound, count)) in buckets.into_iter().enumerate() { + for (i, (upper_bound, count)) in buckets.iter().enumerate() { cummulative += count; self.write_name_and_unit()?; diff --git a/src/registry.rs b/src/registry.rs index e9ee57e..39777f2 100644 --- a/src/registry.rs +++ b/src/registry.rs @@ -54,7 +54,7 @@ use std::borrow::Cow; /// # "# EOF\n"; /// # assert_eq!(expected, buffer); /// ``` -#[derive(Debug)] +#[derive(Debug, Default)] pub struct Registry { prefix: Option, labels: Vec<(Cow<'static, str>, Cow<'static, str>)>, @@ -62,17 +62,6 @@ pub struct Registry { sub_registries: Vec, } -impl Default for Registry { - fn default() -> Self { - Self { - prefix: None, - labels: Default::default(), - metrics: Default::default(), - sub_registries: vec![], - } - } -} - impl Registry { /// Creates a new default [`Registry`] with the given prefix. pub fn with_prefix(prefix: impl Into) -> Self {