Allow tuples of exceptions in ExceptionCounter #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ExceptionCounter.__exit__` kicks down to `isinstance`, which accepts either a single type or a tuple of types (or in Python 3.10, a UnionType). Update type annotations to reflect this. Signed-off-by: Jakob van Santen <jvansanten@gmail.com>
jvansanten
force-pushed
the
count-multiple-exceptions
branch
from
dea991b
to
8a27f80
Compare
jvansanten
added a commit
to AmpelAstro/Ampel-ZTF
that referenced
this pull request
Jan 19, 2023
Can be removed when prometheus/client_python#881 makes it into a release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExceptionCounter.__exit__kicks down toisinstance, which accepts either a single type or a tuple of types (or in Python 3.10, a UnionType). Update type annotations to reflect this.