Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the mmap minimum size #853

Merged
merged 1 commit into from Nov 22, 2022
Merged

Conversation

SuperQ
Copy link
Member

@SuperQ SuperQ commented Nov 14, 2022

Reduce the initial mmap file size from 1MiB to 64KiB. This should reduce the memory and disk overhead for larger numbers of multiprocess workers.

Signed-off-by: SuperQ superq@gmail.com

Reduce the initial mmap file size from 1MiB to 64KiB. This should reduce
the memory and disk overhead for larger numbers of multiprocess workers.

Signed-off-by: SuperQ <superq@gmail.com>
Copy link
Member

@csmarchbanks csmarchbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@csmarchbanks csmarchbanks merged commit 89552cd into master Nov 22, 2022
@SuperQ SuperQ deleted the superq/reduce_mmap_overhead branch November 22, 2022 11:58
SuperQ added a commit to SuperQ/baseplate.py that referenced this pull request Jan 24, 2023
Update to the latest prometheus-client requirement. Mainly to pick up a
reduction in multi-process worker overhead[0].

[0]: prometheus/client_python#853

Signed-off-by: SuperQ <superq@gmail.com>
KTAtkinson added a commit to reddit/baseplate.py that referenced this pull request Apr 6, 2023
Update to the latest prometheus-client requirement. Mainly to pick up a
reduction in multi-process worker overhead[0].

[0]: prometheus/client_python#853

Signed-off-by: SuperQ <superq@gmail.com>
Co-authored-by: Katie Atkinson <katie.atkinson@reddit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants