Use Iterable[Sample] for all sample collection #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure the types are all consistent and use the appropriate NamedTuple. Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
csmarchbanks
force-pushed
the
fix-samples-type
branch
from
aef1343
to
304745f
Compare
fkaleo
approved these changes
Jan 27, 2022
sd2k
reviewed
Jan 27, 2022
There was a problem hiding this comment.
I'm not super familiar with the codebase, but in general I would prefer the functions returning concrete types (Tuple[Sample]) to be annotated as such, unless there's a specific reason for not doing (e.g. they might change in future). Not a massive issue though, and this should be forwards compatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure the types are all consistent and use the appropriate
NamedTuple.