Remove trailing slash from pushgateway URLs #722
Merged
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the push gateway, URLs may be submitted as host or URL. When using an URL scheme, in case user submits URL with a trailing slash (eg: `http://localhost:9091/`), the pushgateway server will reply with a 301 (or 307 depending on the version) redirect that is not handled by the default handler. Leading to a traceback Simply remove any trailing slash from the base URL Signed-off-by: Romuald Brunet <romuald@gandi.net>
romuald
force-pushed
the
push-to-gateway-strip-url
branch
from
b49f903 to
272454d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the push gateway, URLs may be submitted as host or URL.
When using an URL scheme, in case user submits URL with a trailing slash
(eg:
http://localhost:9091/), the pushgateway server will reply with a301 (or 307 depending on the version) redirect that is not handled by
the default handler. Leading to a traceback
Simply remove any trailing slash from the base URL