Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten the buckets of native histograms #59

Merged
merged 1 commit into from Jul 19, 2022
Merged

Conversation

beorn7
Copy link
Member

@beorn7 beorn7 commented Jul 14, 2022

This is only for the sparsehistogram branch.

This is slightly more efficient on the wire, and it matches the way
the corresponding Go types are structured (histogram.Histogram and
histogram.FloatHistogram). This follow the change for the
remote-write protobuf in
prometheus/prometheus#11011 .

This commit also moves away from the "sparse histogram" naming in lieu
of the preferred name "native histogram".

Note that this is deliberately an incompatible change of the proto
spec. Keeping compatibility would cause some hassle but not much gain
because we haven't published the proto spec in any release yet and
always marked it as experimental. Compatibility to the released proto
spec (without native histograms) is kept, of course.

Signed-off-by: beorn7 beorn@grafana.com

This is slightly more efficient on the wire, and it matches the way
the corresponding Go types are structured (`histogram.Histogram` and
`histogram.FloatHistogram`). This follow the change for the
remote-write protobuf in
prometheus/prometheus#11011 .

This commit also moves away from the "sparse histogram" naming in lieu
of the preferred name "native histogram".

Note that this is deliberately an incompatible change of the proto
spec. Keeping compatibility would cause some hassle but not much gain
because we haven't published the proto spec in any release yet and
always marked it as experimental. Compatibility to the released proto
spec (without native histograms) is kept, of course.

Signed-off-by: beorn7 <beorn@grafana.com>
@beorn7 beorn7 merged commit 1f8dcad into sparsehistogram Jul 19, 2022
@beorn7 beorn7 deleted the beorn7/histogram branch July 19, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants