Adding TraceSampling to Examplar Sampler #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fscellos
force-pushed
the
features-sampling
branch
from
0ac1639
to
36995b9
Compare
…llos <fabrice.scellos@soprasteria.com> Signed-off-by: Fabrice Scellos <fabrice.scellos@soprasteria.com>
fscellos
force-pushed
the
features-sampling
branch
from
36995b9
to
9c40fc9
Compare
…ect one for some components Signed-off-by: Fabrice Scellos <fabrice.scellos@soprasteria.com>
|
Hello @fstab. Have you any comments ? |
fstab
requested changes
Mar 14, 2022
...r_common/src/main/java/io/prometheus/client/exemplars/tracer/common/SpanContextSupplier.java
Show resolved
Hide resolved
|
Thank you for your feedback. I'll do it in one week or two. |
Signed-off-by: Fabrice Scellos <fabrice.scellos@soprasteria.com>
fscellos
force-pushed
the
features-sampling
branch
from
6bef846
to
173ea9e
Compare
|
Hello @fstab. |
|
Hello @fstab .Any news ? Does modification ok for you ? |
|
Thanks a lot, and sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR answer to Issue #765 (finally short so i do it shortly too)
@fstab