Bump up caffeine dependencies

[eschizoid]

The purpose of this PR is to add support for the AsyncCache and not only theAsyncLoadingCache

[eschizoid]

hey @checketts wondering if you can give it a quick look to this little guy, thanks!

[brian-brazil]

We purposefully list old versions so that we don't inadvertently break backwards compatibility.

[eschizoid]

We purposefully list old versions so that we don't inadvertently break backwards compatibility.

hey @brian-brazil thanks for your quick reply. Is there any other way we can add support for this new type of caching that caffeine added on recent versions?

This upgrade should not break previous implementations since now both classes share a common interface, hope that helps :)

P.S. I ran the tests and they passed, please let me know if there is any other validation I could do.

[brian-brazil]

So if someone was running 2.3.0, then this wouldn't break them?

[eschizoid]

hey @brian-brazil attached my answers.

So if someone was running 2.3.0, then this wouldn't break them?

Thats is correct, given the following interface:

package com.github.benmanes.caffeine.cache;
...
public interface AsyncLoadingCache<K, V> extends AsyncCache<K, V> {
...
}

Caffeine now offers some other methods that allow you to have an instance of AsyncCache

Let me know what you think :)

[brian-brazil]

I'm not convinced, there is no AsyncCache in 2.3.0.

[eschizoid]

I'm not convinced, there is no AsyncCache in 2.3.0.

correct, so folks that remain on version 0.8.1 won't have problems

Now let's say we merge this PR and folks migrate to version 0.8.2, these folks won't have to change their working code since AsyncCache is the base class for AsyncLoadingCache . Their code will remain as it is, other than having to bump up the dependency.

so folks can do any of this without breaking the existing API:

collector.addCache("existing_cache_implementation", AsyncLoadingCache)
collector.addCache("base_class_implementation", AsyncCache)

the test cases are already proving that exiting code will continue to work.

Would it be helpful if I add some examples on the REAMDE file explaining how to migrate to the new version and take advantage of java inheritance?

If you feel more comfortable we can also do this:

public void addCache(String cacheName, AsyncLoadincCache cache) {
    children.put(cacheName, cache.synchronous());
}

public void addCache(String cacheName, AsyncCache cache) {
    children.put(cacheName, cache.synchronous());
}

I feel is a little bit redundant given what I just explained, please let me know what you think :)

[brian-brazil]

correct, so folks that remain on version 0.8.1 won't have problems

But folks who upgrade to the next version of client_java would. I don't like forcing users to upgrade to new versions of dependencies unless there's a non-trivial gain in terms of the metrics available. Especially when the new version hasn't even been out two weeks yet.

[eschizoid]

I don't like forcing users to upgrade to new versions of dependencies unless there's a non-trivial gain in terms of the metrics available.

I see. I think the java client will get some benefits on the metric side since it will now support the two types of caches that caffeine offers.

Especially when the new version hasn't even been out two weeks yet.

That is fair, I should have been more careful with my suggestion. What about if we bump up to the version where the interface AsyncCache was introduced?

https://github.com/ben-manes/caffeine/blob/v2.7.0/caffeine/src/main/java/com/github/benmanes/caffeine/cache/AsyncCache.java

This artifact was released to maven central (Feb 24, 2019)

@brian-brazil Let me know what you think about this more cautious approach :)

[brian-brazil]

That sounds more reasonable.

[eschizoid]

That sounds more reasonable.

@brian-brazil Done :)

Let me know what you think

[brian-brazil]

Thanks!