Added health check api to the client. #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prometheus/jmx_exporter#465 Signed-off-by: Brajesh Kumar <brjkumar@amazon.com>
|
@brian-brazil Please have a look on my PR please. |
simpleclient_httpserver/src/main/java/io/prometheus/client/exporter/HTTPServer.java
Outdated
Show resolved
Hide resolved
simpleclient_httpserver/src/main/java/io/prometheus/client/exporter/HTTPServer.java
Outdated
Show resolved
Hide resolved
added 2 commits
February 28, 2020 15:19
prometheus/jmx_exporter#465 Signed-off-by: Brajesh Kumar <brjkumar@amazon.com>
Hangleton
reviewed
Feb 28, 2020
simpleclient_httpserver/src/main/java/io/prometheus/client/exporter/HTTPServer.java
Outdated
Show resolved
Hide resolved
simpleclient_httpserver/src/main/java/io/prometheus/client/exporter/HTTPServer.java
Outdated
Show resolved
Hide resolved
simpleclient_httpserver/src/main/java/io/prometheus/client/exporter/HTTPServer.java
Show resolved
Hide resolved
Signed-off-by: Brajesh Kumar <brjkumar@amazon.com>
Hangleton
approved these changes
Feb 28, 2020
|
Thanks! |
This was referenced Mar 11, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added health check api to the client.
When "/-/healthy" is hit, server will return "Exporter is Healthy."
Added Unit test to verify changes are proper and no existing functionality is broken.
prometheus/jmx_exporter#465