Remove the mention of JMX from the included connectors #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Streese <max.streese@ttmzero.com>
maxstreese
force-pushed
the
feature/remove-jmx-mention-in-readme
branch
from
43306e9
to
43fb0d4
Compare
|
All those metrics come from JMX though, so it's not technically wrong... |
|
Hmm it is just that the way it is currently written strongly suggests to me that the call would enable collection of every and all JMX metrics and not that the metrics which are collected just happen to come via JMX. If you disagree feel free to close the PR. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very minor PR but I think it is still important. Currently the README suggests that simply calling
DefaultExports.initialize()will enable JMX metrics collection.This is not the case though and has led to some issues opened here in that past (it did not just confuse me is what I am saying I guess). JMX metrics are not collected when calling the above. Only garbage collection, memory pools, class loading and thread counts are collected.